Subject: Bug#3740: A couple of problems popped up while using "modconf"

From: llucius <[email-masked]>
Date: Tue, 9 Jul 1996 18:38:04 -0500 (CDT)

Package: modconf
Version: 0.1.0-4

While using modconf, I noticed the following problems:

1)  A "Cancel" request was not being honored on the "Enter Command-Line
    Arguments" dialog.  The module would be installed anyway.
2)  Argument help for a module was not being displayed on the "Enter
    Command-Line Arguments" dialog.
3)  Though not truly a critter, the module status was not refreshed after
    installing or removing a module.

Thanks,

Leland

The following patches correct these problems:

--- orig/modconf-0.1.0/modconf	Sun Jun  2 23:50:22 1996
+++ modconf-0.1.0/modconf	Tue Jul  9 18:24:50 1996
@@ -189,7 +189,7 @@
 }
 
 module_argument_help () {
-	if in_list "$module_argument_help_list" $1; then
+	if in_list "$argument_help_list" $1; then
 		sed -e '1d' < $ModuleHelp/arguments/$1
 		echo ""
 	fi
@@ -349,6 +349,7 @@
 	sync
 
 	edit_arguments $module
+	if [ $? -ne 0 ]; then return 1; fi
 
 	echo $clear$bold\
 "Installing module $module. If the device isn't there, or isn't configured
@@ -362,6 +363,7 @@
 	if [ $status -eq 0 ]; then
 		echo "Installation succeeded."
 		echo "$module" >> $Target/etc/modules
+		build_lists
 	else
 		echo "Installation failed."
 	fi
@@ -397,6 +399,8 @@
 	ln $Target/etc/modules $Target/etc/modules.old
 	mv $Target/etc/modules.tmp $Target/etc/modules
 	sync
+
+	build_lists
 
 	return 0
 }