Subject: Bug#3773: xless default window too thin and won't go away when asked nicely

From: Richard Kettlewell <[email-masked]>
Date: Sun, 14 Jul 96 00:41:52 +0100 (BST)

Package: xless
Version: 1.7-1

I did `man xless | xless &' as the obvious test case, and the window
came up somewhat less than 80 characters wide - each line was
truncated by a black blob.

Additionally, the window doesn't go away when I hit the close button
(as added by fvwm).

-- 
Richard Kettlewell   [email-masked]   [email-masked]
                             http://www.elmail.co.uk/staff/richard/

---

From: "James A. Robinson" <[email-masked]>
Date: Sat, 13 Jul 1996 21:12:49 -0400

> truncated by a black blob.

Obviously there is no way for xless to figure out what the longest
line is on STDIN, and I think it would probably be inefficient for it
to figure it out on big files.  I believe the scroll bars at the
bottom are there as a solution to the problem (besides just resizing
the window)

> Additionally, the window doesn't go away when I hit the close button

What? Do you mean the real close button, or do you mean the close
button that your Fvwm puts on the top?  The xless' close button works
for me, and my Afterstep-window close button (bound to "Delete") also
works...  Which button are you using?  If it is the latter, then it is
probably a buggy Fvwm...

Jim

---

From: Richard Kettlewell <[email-masked]>
Date: Sun, 14 Jul 96 14:19:49 +0100 (BST)

James A. Robinson writes:

>line is on STDIN,

No, as it reads the whole file into memory before even opening a
window, even when reading solely from stdin.

>and I think it would probably be inefficient for it to figure it out
>on big files.

Look at init.c:fixNewText.  It *does* attempt to work out the width.
Obviously it's incorrectly using the information later on.

>I believe the scroll bars at the bottom are there as a solution to
>the problem (besides just resizing the window)

It'll work, but it's not the best solution.

>>Additionally, the window doesn't go away when I hit the close button

(The same applies to the `help' window.)

>button that your Fvwm puts on the top?

I mean the one added by Fvwm.

>The xless' close button works for me, and my Afterstep-window close
>button (bound to "Delete") also works...  Which button are you using?

It's bound to `Delete' in my ~/.fvmwrc file.

>If it is the latter, then it is probably a buggy Fvwm...

Perhaps, but given that the button works for every other program I can
think of that I use, suspect the bug is in xless...

---

From: "James A. Robinson" <[email-masked]>
Date: Sun, 14 Jul 1996 13:33:35 -0400

> Obviously it's incorrectly using the information later on.

Ok, I will pass this upstream.

> think of that I use, suspect the bug is in xless...

Ok -- perhaps it is a feature of Afterstep that this works on mine.  I
will pass it along.

Jim