Subject: Bug#4375: Hello forgets to increment loop counter when reading mailbox

From: Peter Benie <[email-masked]>
Date: Mon, 2 Sep 1996 11:26:15 +0100 (BST)

Package: hello
Version: 1.3-12

1) Line 196-201 contain the following loop:
	  d = dirs;
	  do
	    {
	      sprintf (mailname, "%s/%s", *d, user);
	      mailfd = open (mailname, O_RDONLY);
	    } while (mailfd == -1 && (errno == ENOENT || errno == ENOTDIR));

The loop variable, d, is not incremented. Hello will not exit if
a) $MAIL is not set, and b) /usr/spool/mail is not the user's mailbox.

2) `hello' looks under /usr/spool rather than /var/spool.
(Not serious, but IMHO, should be corrected.)

3) `hello' lacks a manpage.

Peter Benie